Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/graphite: fix beacon config parameter #21441

Merged
merged 1 commit into from Dec 27, 2016
Merged

nixos/graphite: fix beacon config parameter #21441

merged 1 commit into from Dec 27, 2016

Conversation

Lassulus
Copy link
Member

Motivation for this change

services.graphite.beacon currently doesn't work.

Following error occurs during launch:

Traceback (most recent call last):
  File "/nix/store/5f2xayl4dirw80svbmn0gzishrm0a6xz-python2.7-graphite_beacon-0.22.1/bin/.graphite-beacon-wrapped", line 12, in <module>
    sys.exit(run())
  File "/nix/store/5f2xayl4dirw80svbmn0gzishrm0a6xz-python2.7-graphite_beacon-0.22.1/lib/python2.7/site-packages/graphite_beacon/app.py", line 14, in run
    options.parse_command_line()
  File "/nix/store/f81aar4gipmync6jnbs967zcan0nw2lw-python2.7-tornado-4.4.2/lib/python2.7/site-packages/tornado/options.py", line 293, in parse_command_line
    raise Error('Option %r requires a value' % name)
tornado.options.Error: Option 'config' requires a value
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Lassulus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @offlinehacker, @bjornfor and @makefu to be potential reviewers.

@makefu
Copy link
Contributor

makefu commented Dec 27, 2016

lgtm

@Mic92 Mic92 merged commit cfbe501 into NixOS:master Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Lassulus @mention-bot @makefu @Mic92