packer: 0.10.1 -> 0.12.1 #21469
packer: 0.10.1 -> 0.12.1 #21469
Conversation
Update was done using new `updateScript`. Not the prettiest thing, but it works.
| ''; | ||
|
|
||
| passthru.updateScript = writeScript "update-packer" '' | ||
| #!${bash}/bin/bash |
There was a problem hiding this comment.
why don't use https://github.com/kamilchm/go2nix?
There was a problem hiding this comment.
I've tried to do it, but it wasn't able to catch all those extra deps that are specified in vendor/vendor.json in packer repository - resulting .nix-file contained only packer sources itself.
There was a problem hiding this comment.
did you try to run make deps in packer source before go2nix save?
There was a problem hiding this comment.
ok, it's something inconsistent in packer vendor dir, it looks like it's half managed by govendor with not all deps checked in into its repo
| mv bin/* $out/bin # */ | ||
| ''; | ||
|
|
||
| passthru.updateScript = writeScript "update-packer" '' |
There was a problem hiding this comment.
I think this would be better served with a separate .sh file and substituteInPlace for the PATH and what-not. what do you think, @garbas? Seems not good having this in line.
There was a problem hiding this comment.
Can you run shellcheck on this script? It looks pretty complicated, I think shellcheck would be good for maintainability.
There was a problem hiding this comment.
probably it would be good to have this in a separate file. but i understand why it is done inline, it is just easier to iterate. i would say it is up to a maintainer of the package to decide what is easier for them.
|
Hey all. The packer build used to be very complicated but has been made much easier now through vendoring. I went ahead and made another simplified version over here: #21656 , unfortunately it's missing the update script. |
|
Is there anything to salvage from this PR? |
|
No. |
Update was done using
updateScriptthat was also added by this commit.Not the prettiest thing, but it works.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)