Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bloaty: 2016.11.16 -> 2016.12.28 #21472

Merged
merged 1 commit into from Dec 29, 2016
Merged

bloaty: 2016.11.16 -> 2016.12.28 #21472

merged 1 commit into from Dec 29, 2016

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 28, 2016

Motivation for this change

Minor update.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

rasendubi
rasendubi approved these changes Dec 29, 2016
View reviewed changes
Copy link
Member

@rasendubi rasendubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Builds fine on Gentoo+Nix.

@rasendubi rasendubi merged commit cb68078 into NixOS:master Dec 29, 2016
@dtzWill dtzWill deleted the update/bloaty branch December 29, 2016 19:53
@dtzWill
Copy link
Member Author

dtzWill commented Dec 29, 2016

Thanks @rasendubi!

@rasendubi
Copy link
Member

rasendubi commented Dec 29, 2016 •
edited

@dtzWill, you're welcome! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasendubi rasendubi rasendubi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @rasendubi