Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ricochet: 1.1.2 -> 1.1.4 #21458

Merged
merged 1 commit into from
Dec 28, 2016
Merged

ricochet: 1.1.2 -> 1.1.4 #21458

merged 1 commit into from
Dec 28, 2016

Conversation

np
Copy link
Contributor

@np np commented Dec 28, 2016 •
edited

Motivation for this change

Try the latest version

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@np, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zimbatm, @jgillich and @codsl to be potential reviewers.

@zimbatm
Copy link
Member

zimbatm commented Dec 28, 2016 •
edited

@np can you check the Travis result? It looks like pythonOlder hasn't been imported in the derivation context.

EDIT: urlscan is unrelated to this PR, someone has broken master
EDIT2: fixed in 842a301

@zimbatm zimbatm merged commit 5952897 into NixOS:master Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@np @mention-bot @zimbatm