Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

natron: init at 2.1.9 #21455

Merged
merged 1 commit into from Jan 6, 2017
Merged

natron: init at 2.1.9 #21455

merged 1 commit into from Jan 6, 2017

Conversation

puffnfresh
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@rasendubi
Copy link
Member

Failed to build on Gentoo+Nix:

rasen@ashmalko ~/nixpkgs> nix build natron
error: getting attributes of path ‘/home/rasen/nixpkgs/pkgs/applications/video/natron/config.pri’: No such file or directory
(use ‘--show-trace’ to show detailed location information)

@puffnfresh
Copy link
Contributor Author

@rasendubi thanks I forgot to commit that file.

rasendubi
rasendubi approved these changes Dec 28, 2016
View reviewed changes
Copy link
Member

@rasendubi rasendubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superficially looks good to me. Builds fine on Gentoo+Nix.

FRidh
FRidh reviewed Dec 30, 2016
View reviewed changes
pkgs/applications/video/natron/default.nix
pkgconfig qt4 boost expat cairo pythonPackages.pyside pythonPackages.pysideShiboken
];

nativeBuildInputs = [ qmake4Hook python2Packages.wrapPython ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python2Packages or pythonPackages

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, not both.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a let pythonPackages = python2Packages just above.

@FRidh FRidh merged commit 4187179 into NixOS:master Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@FRidh FRidh FRidh left review comments

@rasendubi rasendubi rasendubi approved these changes

Assignees
No one assigned
Labels
8.has: package (new)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@puffnfresh @rasendubi @Mic92 @FRidh @fpletz