Fontconfig for Android Studio #21462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phunehehe, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bjornfor, @taku0 and @edwtjo to be potential reviewers. |
This was referenced Dec 28, 2016
phunehehe
force-pushed
the
android-studio
branch
from
6c08224
to
26cb613
Compare
grahamc
reviewed
Dec 30, 2016
| # jdk = pkgs.oraclejdk8; | ||
| # }; | ||
| # }; | ||
| # } |
There was a problem hiding this comment.
Because it's no longer true. This version of android studio bundles its own JDK.
phunehehe
force-pushed
the
android-studio
branch
from
26cb613
to
a5cb303
Compare
Android Studio now bundles its own JDK ¯\_(ツ)_/¯
phunehehe
force-pushed
the
android-studio
branch
from
a5cb303
to
4b3f79b
Compare
|
Is this still good to merge? |
|
It is. The only concern I had was about fontconfig. If nobody chips in I guess it's not really a problem. |
|
If someone is impacted by this, change, hopefully they'll file an issue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
With the fonts.conf by Ubuntu (I use Nix instead of Apt on Ubuntu), Android Studio crashes during startup because it fails to do some font stuff. With a config file built with
makeFontsConf(even an empty one!?), it works fine. The workaround is found via docker-library/openjdk#73.On the one side, it could be argued that I should fix my fonts.conf, but then it means the package isn't really usable out of NixOS.
On the other side, overriding FONTCONFIG_FILE probably means the package can't use all the installed fonts, but then I also see other packages doing the same.
Thoughts?
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)