zsh-autosuggestions: init at 0.3.3 #21792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacinehmito
force-pushed
the
zsh-autosuggestions
branch
2 times, most recently
from
a546237
to
7ff69a2
Compare
Mic92
approved these changes
Jan 10, 2017
|
|
||
| installPhase = '' | ||
| install -d $out/share/zsh-autosuggestions | ||
| install zsh-autosuggestions.zsh \ |
There was a problem hiding this comment.
you can skip the first install by adding -D to the second one.
|
|
||
| buildInputs = [ zsh ]; | ||
|
|
||
| buildPhase = ""; |
There was a problem hiding this comment.
buildPhases = [ "unpackPhase" "installPhase" ]; instead of empty buildPhase.
| stdenv.mkDerivation rec { | ||
| name = "${pkgName}-${version}"; | ||
|
|
||
| src = fetchurl { |
There was a problem hiding this comment.
fetchFromGitHub can be used here.
yacinehmito
force-pushed
the
zsh-autosuggestions
branch
from
7ff69a2
to
dca0d65
Compare
|
Thanks @Mic92 for the suggestions of improvement. The commit has been changed accordingly. Weirdly enough, the hash didn't stay the same when I switched to fetchFromGitHub. |
Added a related `programs.zsh.enableAutosuggestions` option
yacinehmito
force-pushed
the
zsh-autosuggestions
branch
from
dca0d65
to
7c62e12
Compare
That's to be expected because fetchFromGitHub normalizes the timestamps in the archive in case Github chooses to rebuild the tarball. |
fpletz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
PR #19179 added zsh-syntax-highlighting. I needed zsh-autosuggestions, which is a plugin often paired with it as they both provide a fish-like experience.
Things done
Added the zsh-autosuggestions package.
Added also a related
programs.zsh.enableAutosuggestionsoption, as advised in #19179@loskutov, I left you as a maintainer given your work on packaging zsh-syntax-highlighting.
Let me know if it's ok for you or if you want me to change that.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)