ZfsUnstable: 0.7.0-rc2 -> 0.7.0-rc3 #22020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mic92 I'm not sure if we should to be honest. Maybe downgrade the error to a warning? One thing which is a little bit annoying from feedback from "my" users is that they don't know how to enable the unstable version, so I pushed a commit that adds a hint to the error message. |
fpletz
approved these changes
Jan 21, 2017
Mic92
commented
Jan 21, 2017
| throw "linux v${kernel.version} is not yet supported by zfsonlinux v${version}" | ||
| (incompatibleKernelVersion != null) && | ||
| versionAtLeast kernel.version incompatibleKernelVersion then | ||
| throw "Linux v${kernel.version} is not yet supported by zfsonlinux v${version}. Try zfsUnstable or set the NixOS option boot.zfs.enableUnstable." |
There was a problem hiding this comment.
this error message might become a problem, once unstable is also not compatible with mainline...
There was a problem hiding this comment.
Yup. That's why I wrote "Try". 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
As the default LTS kernel now requires zfsUnstable should we enable it by default? @fpletz
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)