Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tahoe-LAFS version bump #22028

Merged
merged 4 commits into from Jan 24, 2017
Merged

Tahoe-LAFS version bump #22028

merged 4 commits into from Jan 24, 2017

Conversation

MostAwesomeDude
Copy link
Contributor

Motivation for this change

Tahoe-LAFS 1.12 came out.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I've tested the new "Magic Folder" functionality on two NixOS clients. I've also deployed the server to a live grid, and it is working great.

@mention-bot
Copy link

@MostAwesomeDude, thanks for your PR! By analyzing the history of the files in this pull request, we identified @domenkozar, @peti, @garbas and @FRidh to be potential reviewers.

@grahamc
Copy link
Member

grahamc commented Jan 22, 2017

I think this LGTM, except the first commit should be split in to two -- one for each package.

@MostAwesomeDude
Copy link
Contributor Author

I've split that first commit as requested. I didn't check bisectability, but it should be fine as long as Foolscap is updated before Tahoe.

@7c6f434c 7c6f434c merged commit 47661c8 into NixOS:master Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants