Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: fix tests on darwin #22027

Merged
merged 2 commits into from Jan 23, 2017
Merged

go: fix tests on darwin #22027

merged 2 commits into from Jan 23, 2017

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jan 22, 2017

Motivation for this change

This should fix go_bootstrap and go_1_6 on darwin

Things done
  • Tested using sandboxing / without xcode
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • macOS
    • No changes for other platforms
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 added 6.topic: darwin Running or building packages on Darwin 6.topic: golang labels Jan 22, 2017
@LnL7 LnL7 merged commit e026568 into NixOS:master Jan 23, 2017
@LnL7 LnL7 deleted the darwin-go branch January 23, 2017 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: golang
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@LnL7