New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bundleEnv: Used gemdir for most applications now #21962
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Mic92, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peterhoeg, @jgertm and @namore to be potential reviewers. |
Mic92
changed the title
bundleEnv: Use gemdir for mosth applications now
bundleEnv: Use gemdir for most applications now
Jan 18, 2017
Mic92
changed the title
bundleEnv: Use gemdir for most applications now
bundleEnv: Used gemdir for most applications now
Jan 18, 2017
LnL7
approved these changes
Jan 18, 2017
Was this also changed in bundix? |
@LnL7 the change is independent of bundix. I did not find sample code in the bundix repo, which would require a change. |
Thanks @Mic92 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I replaced in every healthy package
gemfile
,lockfile
,gemset
withgemdir
.@zimbatm
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)