mitmproxy: 0.17.1 -> 1.0.2 #21639
Merged
mitmproxy: 0.17.1 -> 1.0.2 #21639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
requested changes
Jan 4, 2017
| watchdog editorconfig | ||
| ]; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
no tests? Please always include a comment with the reason why tests are disabled.
| }; | ||
|
|
||
| propagatedBuildInputs = with self; [ six ]; | ||
|
|
||
| doCheck = !isPy3k; |
| src = pkgs.fetchurl { | ||
| url = "mirror://pypi/s/sortedcontainers/${name}.tar.gz"; | ||
| sha256 = "1sjh8lccbmvwna91mlhl5m3z4320p07h063b8x8br4p4cll49w0g"; | ||
| }; | ||
|
|
||
| doCheck = false; |
| }; | ||
|
|
||
| propagatedBuildInputs = with self; [ ruamel_base ruamel_ordereddict ]; | ||
| doCheck = false; |
|
Added comments with explanations for disabling the tests. I don't have time to fix the tests and packaging new and bumping existing python packages was tedious enough for me. As indicated above, I have not run |
fpletz
force-pushed
the
pkg/mitmproxy
branch
2 times, most recently
from
a5a6278
to
d8646bd
Compare
|
Okay, so all reverse dependencies build for me with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
mitmproxy was marked as broken and needed fixing and a version bump.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)