Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkvtoolnix: 9.6.0 -> 9.8.0 #22111

Merged
merged 1 commit into from Jan 24, 2017
Merged

mkvtoolnix: 9.6.0 -> 9.8.0 #22111

merged 1 commit into from Jan 24, 2017

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jan 24, 2017

Motivation for this change
  • Update MKVToolNix to v9.8.0.
  • Add a build dependency on drake, because it is not bundled with MKVToolNix anymore since v9.8.0.
  • CURL is no longer used by MKVToolNix so the corresponding configure option is not valid anymore.
  • Changes: https://mkvtoolnix.download/doc/NEWS.md
New build dependency

From now on MKVToolNix needs an external version of the drake package, which is added to the repository in pull request #22106.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

- Update mkvtoolnix to v9.8.0
- Add a build dependency on drake, because it is not bundled with
  mkvtoolnix anymore since v9.8.0
@mention-bot
Copy link

@romildo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dguibert, @rnhmjoj and @codyopel to be potential reviewers.

@romildo romildo mentioned this pull request Jan 24, 2017
7 tasks
@7c6f434c 7c6f434c merged commit 9977fb8 into NixOS:master Jan 24, 2017
@romildo romildo deleted the upd.mkvtoolnix branch January 24, 2017 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants