apache-kafka service: change default brokerId to -1 #22103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A default of 0 means that if you deploy two NixOS boxes with the default configuration, the second will fail because the brokerId was already in use. Using -1 instead tells it to pick one automatically at first start.
|
@copumpkin, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ragnard, @edolstra and @joachifm to be potential reviewers. |
grahamc
approved these changes
Jan 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A default of 0 means that if you deploy two NixOS boxes with the default configuration, the second will fail because the brokerId was already in use. Using -1 instead tells it to pick one automatically at first start.
Fixes #22100
cc @ragnard @shlevy