Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jwm: 1563 -> 1575 #22113

Merged
merged 1 commit into from Jan 24, 2017
Merged

jwm: 1563 -> 1575 #22113

merged 1 commit into from Jan 24, 2017

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jan 24, 2017

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@romildo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MarcWeber, @7c6f434c and @edolstra to be potential reviewers.

@7c6f434c 7c6f434c merged commit 90b2621 into NixOS:master Jan 24, 2017
@7c6f434c
Copy link
Member

Maybe you should ask @rbvermaa for commit rights? I think it is high time that these are granted to you…

@romildo romildo deleted the upd.jwm branch January 24, 2017 22:05
@romildo
Copy link
Contributor Author

romildo commented Jan 24, 2017

@rbvermaa can I get commit rights? They would make me more helpful to the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants