Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 5f85cb8fdecc
Choose a base ref
...
head repository: jruby/jruby
compare: afe3b28de09e
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Jan 19, 2017

  1. Don't use reflection to define classes, since Java 9 hates it. 

    Java 9 errors when we try to make defineClass accessible on
ClassLoader, due to accessibility of the java.lang module. It
turns out we don't need to do this, anyway, because the only
ClassLoader passed in is a JRubyClassLoader, which implements
ClassDefiningClassLoader and exposes defineClass publicly.
    @headius
    headius committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    6926296 View commit details
    Browse the repository at this point in the history

  2. Disable setAccessible in JI when on Java 9. 

    Java 9's module system requires us to do a bit more work to
set methods accessible within java.lang and other modules. If we
fail to do this, the method raises InaccessibleObjectException,
a Java 9-specific exception we can't catch in Java 8 code. For the
moment we will disable setAccessible use on Java 9 so JRuby can
start up and run correctly.
    @headius
    headius committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    afe3b28 View commit details
    Browse the repository at this point in the history