Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yubioath-desktop application and required pyscard module #21983

Merged
merged 1 commit into from Jan 19, 2017

Conversation

jonmeredith
Copy link

Motivation for this change

Adds support for the YubiKey OTP desktop app. Yubikeys are hardware authentication tokens you can use for 2FA. There's already some support in Nix.

The derivation should build without a Yubikey, you just won't be able to use it.

With YubiKey inserted.

jon@jdmt460s> ./result/bin/yubioath                             ~/nixos/nixpkgs
GitHub:ronmeredith      xxxxxx

And without

jon@jdmt460s> ./result/bin/yubioath                             ~/nixos/nixpkgs
Usage: yubioath show [OPTIONS] [QUERY]...

Error: No YubiKey found!

(apologies for the first pull request on this - it came from the wrong account so I close it)

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@jonmeredith, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@7c6f434c 7c6f434c merged commit 7f2769f into NixOS:master Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants