Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages: Add js-beautify #21980

Closed
wants to merge 1 commit into from
Closed

Conversation

jbaum98
Copy link
Contributor

@jbaum98 jbaum98 commented Jan 18, 2017

Motivation for this change

Add js-beautify to nodePackages

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@CMCDragonkai
Copy link
Member

Is this still working? If so it would be great integration into the js2mode of spacemacs

@jbaum98
Copy link
Contributor Author

jbaum98 commented Jun 19, 2017

I accidentally closed this when trying to redo this commit to fix the merge conflicts, my bad.

@jbaum98 jbaum98 reopened this Jun 19, 2017
@jbaum98
Copy link
Contributor Author

jbaum98 commented Jun 19, 2017

This one has no merge conflicts and definitely still builds on my machine.

@ghost
Copy link

ghost commented Jul 13, 2017

@Mic92 please merge :)

@Mic92 Mic92 closed this in 3ef073e Jul 14, 2017
@jbaum98 jbaum98 deleted the js-beautify branch July 24, 2017 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants