Add renegotiation cb #121
Merged
Add renegotiation cb #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lampad well done, thanks! |
kares
added a commit
that referenced
this pull request
Mar 2, 2017
* 'master' of github.com:jruby/jruby-openssl: Add renegotiation cb (#121)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to resolve: #120
Let me know if you think the callback call is in the correct place. Based on comparing what CRuby does, which basically delegates to OpenSSL, I think the current location makes the most sense, but I also played around with putting it at the start of the doHandshake() method.
I had some difficulty getting my environment set up correctly, and wasn't able to run the full ruby test suite, but the java tests and the tests in the test_ssl.rb pass. I'm hoping the CI keeps me honest.