Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbound 1.5.10 -> 1.6.0 #21526

Merged
merged 5 commits into from
Dec 30, 2016
Merged

unbound 1.5.10 -> 1.6.0 #21526

merged 5 commits into from
Dec 30, 2016

Conversation

dbalan
Copy link
Contributor

@dbalan dbalan commented Dec 30, 2016

Motivation for this change

New release

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Massimo Zaniboni and others added 5 commits December 29, 2016 23:00
Before this fix, apropos behaved exactly like whatis and looked for
an exact match. Now, it actually provides the apropos-functionality
of searching.
…wsfeed

Python sphinxcontrib-newsfeed-0.1.4
@mention-bot
Copy link

@dbalan, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joachifm, @leenaars and @vcunat to be potential reviewers.

@vcunat vcunat changed the title unbound 1.5.6 > 1.6.0 unbound 1.5.10 -> 1.6.0 Dec 30, 2016
@vcunat vcunat changed the base branch from master to staging December 30, 2016 17:22
@vcunat
Copy link
Member

vcunat commented Dec 30, 2016

(Rebuild impact is nontrivial due to being a dependency of gnutls; github now shows a few extra commits from master.)

@joachifm
Copy link
Contributor

As I recall, it has to do with gnutls using unbound for DANE support, is that something people actually use?

@vcunat
Copy link
Member

vcunat commented Dec 30, 2016

I don't know; I would personally be inclined to push people towards DANE a bit, but I probably can't be really objective in this.

@vcunat
Copy link
Member

vcunat commented Dec 30, 2016

It does seem probable that noone uses libgnutls-dane in nixpkgs yet, even though we've been providing it for a long time already.

@leenaars
Copy link
Contributor

We use that, with quite some stuff that is on its way ;)

@leenaars
Copy link
Contributor

And like @vcunat says: it is the Right Thing for people. Having it in nixpkgs makes it available everywhere fast.

@vcunat vcunat merged commit cab497e into NixOS:staging Dec 30, 2016
vcunat added a commit that referenced this pull request Dec 30, 2016
@vcunat
Copy link
Member

vcunat commented Feb 27, 2017

Currently this leads to a surprising dependency of gnutls on openssl :-) libgnutls-dane.so -> libunbound.so -> libssl.so

@vcunat
Copy link
Member

vcunat commented Feb 27, 2017

It will probably be preferable to switch unbound directly to nettle instead of gnutls, especially as gnutls does depend on nettle anyway. Debian has done that in testing already.

@vcunat
Copy link
Member

vcunat commented Feb 27, 2017

Ugh, well, it's not so easy as I imagined. The library would probably have to be built separately, and whole unbound seemingly needs more than nettle (libssl.so again on Debian).

@vcunat
Copy link
Member

vcunat commented Feb 27, 2017

It turned out to be not too complicated: #23245.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants