Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releaseTools.debBuild: split checkinstall into separate phase #21531

Closed
wants to merge 1 commit into from

Conversation

abbradar
Copy link
Member

@abbradar abbradar commented Dec 30, 2016

…ow to override them

Motivation for this change

This is needed for NixOS/nix#1141 that improves situation with Nix Debian packages.

Continues #20767

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This breaks compatibility with current Nix's release.nix because postInstall now runs after make install and not after a resulting Debian package is installed (which seems more "right" to me). Because of this we need to merge those two PRs simultaneously.

@mention-bot
Copy link

@abbradar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @rbvermaa and @Profpatsch to be potential reviewers.

@@ -87,12 +90,12 @@ vmTools.runInLinuxImage (stdenv.mkDerivation (
echo "file deb-extra $(ls $i/debs/*.deb | sort | head -1)" >> $out/nix-support/hydra-build-products
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ls is meant to be for human consumption. Not to be used in scripts.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, seems I've missed your message a long time ago. Do you perhaps remember what did you mean? I haven't changed this line so I'm unsure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abbradar 0xABAB was banned from the project about half a year ago, since they left lots of unnecessary/toxic comments on issues/PRs.

@mmahut
Copy link
Member

mmahut commented Aug 3, 2019

What is the status of this pull request?

@abbradar
Copy link
Member Author

abbradar commented Aug 9, 2019

This shouldn't be needed now as my Nix PR is superseded with FPM package generation.

@abbradar abbradar closed this Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants