Remove client-side chat prediction. (#5055)

red-001 · nerzhul · commit 2f56a00d9eef · 2017-01-17T00:09:47.000+01:00
Network lag isn't really a big issue with chat and chat prediction makes writing mods harder.
diff --git a/builtin/game/features.lua b/builtin/game/features.lua
@@ -10,6 +10,7 @@ core.features = {
 	texture_names_parens = true,
 	area_store_custom_ids = true,
 	add_entity_with_staticdata = true,
+	no_chat_message_prediction = true,
 }
 
 function core.has_feature(arg)
diff --git a/src/client.cpp b/src/client.cpp
@@ -1563,10 +1563,13 @@ void Client::typeChatMessage(const std::wstring &message)
 	}
 	else
 	{
-		LocalPlayer *player = m_env.getLocalPlayer();
-		assert(player != NULL);
-		std::wstring name = narrow_to_wide(player->getName());
-		m_chat_queue.push((std::wstring)L"<" + name + L"> " + message);
+		// compatibility code
+		if (m_proto_ver < 29) {
+			LocalPlayer *player = m_env.getLocalPlayer();
+			assert(player != NULL);
+			std::wstring name = narrow_to_wide(player->getName());
+			m_chat_queue.push((std::wstring)L"<" + name + L"> " + message);
+		}
 	}
 }
 
diff --git a/src/network/networkprotocol.h b/src/network/networkprotocol.h
@@ -142,6 +142,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 		Server doesn't accept TOSERVER_BREATH anymore
 		serialization of TileAnimation params changed
 		TAT_SHEET_2D
+		Removed client-sided chat perdiction
 */
 
 #define LATEST_PROTOCOL_VERSION 29
diff --git a/src/server.cpp b/src/server.cpp
@@ -2826,7 +2826,15 @@ std::wstring Server::handleChat(const std::string &name, const std::wstring &wna
 
 		std::vector<u16> clients = m_clients.getClientIDs();
 
+		/*
+			Send the message back to the inital sender
+			if they are using protocol version >= 29
+		*/
+
 		u16 peer_id_to_avoid_sending = (player ? player->peer_id : PEER_ID_INEXISTENT);
+		if (player->protocol_version >= 29)
+			peer_id_to_avoid_sending = PEER_ID_INEXISTENT;
+
 		for (u16 i = 0; i < clients.size(); i++) {
 			u16 cid = clients[i];
 			if (cid != peer_id_to_avoid_sending)

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@ core.features = {`
`10`	`10`	`texture_names_parens = true,`
`11`	`11`	`area_store_custom_ids = true,`
`12`	`12`	`add_entity_with_staticdata = true,`
	`13`	`+ no_chat_message_prediction = true,`
`13`	`14`	`}`
`14`	`15`
`15`	`16`	`function core.has_feature(arg)`
Original file line number	Diff line number	Diff line change
`@@ -1563,10 +1563,13 @@ void Client::typeChatMessage(const std::wstring &message)`
`1563`	`1563`	`}`
`1564`	`1564`	`else`
`1565`	`1565`	`{`
`1566`		`- LocalPlayer *player = m_env.getLocalPlayer();`
`1567`		`- assert(player != NULL);`
`1568`		`- std::wstring name = narrow_to_wide(player->getName());`
`1569`		`- m_chat_queue.push((std::wstring)L"<" + name + L"> " + message);`
	`1566`	`+ // compatibility code`
	`1567`	`+ if (m_proto_ver < 29) {`
	`1568`	`+ LocalPlayer *player = m_env.getLocalPlayer();`
	`1569`	`+ assert(player != NULL);`
	`1570`	`+ std::wstring name = narrow_to_wide(player->getName());`
	`1571`	`+ m_chat_queue.push((std::wstring)L"<" + name + L"> " + message);`
	`1572`	`+ }`
`1570`	`1573`	`}`
`1571`	`1574`	`}`
`1572`	`1575`