cpu-freq: Try powersave if ondemand is not available #21423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gnidorah, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @peti and @Mathnerd314 to be potential reviewers. |
|
Probably figuring correct governor on install stage and setting it at hardware-configuration.nix should be a better approach (if that's possible). |
|
See e.g., |
This reverts commit 4dc56db.
|
@joachifm Okay, let's try this 2c8253c325834e16251936e994c100e893d79253 |
grahamc
reviewed
Dec 29, 2016
| @@ -69,9 +69,6 @@ in | |||
|
|
|||
| config = mkIf cfg.enable { | |||
|
|
|||
| # FIXME: Implement powersave governor for sandy bridge or later Intel CPUs | |||
| powerManagement.cpuFreqGovernor = mkDefault "ondemand"; | |||
|
|
|||
There was a problem hiding this comment.
Probably should keep this, since almost nobody reruns the config generator.
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This should fix default governor picking on Sandy Bridge+ chips and close #9611
Not all people monitor their CPUs at least eventually. And we don't want them to shorten lives of their machines.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)