Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awesome: 3.5.9 -> 4.0 #21430

Merged
merged 1 commit into from Dec 28, 2016
Merged

awesome: 3.5.9 -> 4.0 #21430

merged 1 commit into from Dec 28, 2016

Conversation

rasendubi
Copy link
Member

Motivation for this change

Awesome wm 4.0 released

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I'm currently running awesome-4.0 as my window manager. \o/

@mention-bot
Copy link

@rasendubi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @romildo, @lovek323 and @lethalman to be potential reviewers.

@grahamc
Copy link
Member

grahamc commented Dec 26, 2016

  1. Is there a really good reason to keep 3.4 around?
  2. Is there a really good reason to keep 3.5 around?
  3. Is there a really good reason to expose an attribute named awesome-4-0?

@rasendubi
Copy link
Member Author

awesome-3.4, awesome-3.5 and awesome-4.0 are not compatible, which means people must adapt their configs to the new version. That's why keeping 3.5 is reasonable.

As for 3.4, there still might be users who haven't migrated to 3.5. (Though, I don't know any usage statistics.)

As for naming, I've just followed the pattern—I'm fine with renaming it to awesome-4_0 if you like that.

@grahamc
Copy link
Member

grahamc commented Dec 27, 2016 via email

@rasendubi
Copy link
Member Author

I would like to keep both awesome-4_0 and awesome as an alias. This allows people to request a specific version, so they are not affected once awesome-4.1 is released. (Which could come as a surprise to them and break their system.)

I think we should probably drop 3.4, but am not a user. I suspect it is
old enough to not be receiving patches or updates, and users should be
updating anyway.

Agree.

@rasendubi
Copy link
Member Author

ping. have I addressed all the comments?

@grahamc grahamc merged commit 5306122 into NixOS:master Dec 28, 2016
@flosse
Copy link
Contributor

flosse commented Jan 2, 2017

Unfortunately there's now an error: awesomeWM/awesome#1348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants