New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
awesome: 3.5.9 -> 4.0 #21430
awesome: 3.5.9 -> 4.0 #21430
Conversation
@rasendubi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @romildo, @lovek323 and @lethalman to be potential reviewers. |
|
awesome-3.4, awesome-3.5 and awesome-4.0 are not compatible, which means people must adapt their configs to the new version. That's why keeping 3.5 is reasonable. As for 3.4, there still might be users who haven't migrated to 3.5. (Though, I don't know any usage statistics.) As for naming, I've just followed the pattern—I'm fine with renaming it to |
Alexey Shmalko <notifications@github.com> writes:
awesome-3.4, awesome-3.5 and awesome-4.0 are not compatible, which
means people must adapt their configs to the new version. That's why
keeping 3.5 is reasonable.
Sounds good.
As for 3.4, there still might be users who haven't migrated to 3.5.
(Though, I don't know any usage statistics.)
I think we should probably drop 3.4, but am not a user. I suspect it is
old enough to not be receiving patches or updates, and users should be
updating anyway.
As for naming, I've just followed the pattern—I'm fine with renaming
it to `awesome-4_0` if you like that.
Makes sense, but if the answer was "just in case people want the old
ones", I'd recommend renaming to just "awesome". Since the versions are
very incompatible, we can/should keep one around for at least a bit I
guess.
…
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#21430 (comment)
|
I would like to keep both
Agree. |
ping. have I addressed all the comments? |
Unfortunately there's now an error: awesomeWM/awesome#1348 |
Motivation for this change
Awesome wm 4.0 released
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)I'm currently running awesome-4.0 as my window manager. \o/