procmail: unbreak "make install" #21427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikesperber, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gebner, @MarcWeber and @edolstra to be potential reviewers. |
|
LGTM otherwise. |
|
It'd be nice to have upstream fix this. It's their bug. |
|
I don't think upstream is active anymore as http://www.procmail.org/ is down and latest release is from 2001 according to Wikipedia. |
|
Bjørn Forsman <notifications@github.com> writes:
It'd be nice to have upstream fix this. It's their bug.
It would, but procmail hasn't had an upstream for probably a decade or
so.
|
|
Gabriel Ebner <notifications@github.com> writes:
`make install` works fine on linux, so could you please mention in the
comment that this is a mac-specific fix? Otherwise somebody might
accidentally remove it in the future.
Good point, done. Thanks for the review!
|
procmail's Makefile lacks a ".PHONY: install" line, which turns "make install" into a no-op, at least on macOS. Insert one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
procmail's Makefile lacks a ".PHONY: install" line, which turns "make
install" into a no-op, at least on macOS. Insert one.
Motivation for this change
nix-env -i procmail would not install anything into the store.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)