Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not only linux #21431

Merged
merged 7 commits into from Dec 26, 2016
Merged

Not only linux #21431

merged 7 commits into from Dec 26, 2016

Conversation

mitchty
Copy link
Contributor

@mitchty mitchty commented Dec 26, 2016

Motivation for this change

I wanted to use these packages on OS X without local changes in my fork, note, that for most of the packages its unlikely they are linux specific. Adjusted all platforms to build on any unix platform.

I've been running with these changes on osx for about 2-3 months successfully as a note, with cscope being the most problematic on OS X.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@mitchty, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @bjornfor and @dezgeg to be potential reviewers.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Dec 26, 2016
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing...

@LnL7 LnL7 merged commit 72cc140 into NixOS:master Dec 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants