Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Socket.unix #3798

Merged
merged 1 commit into from Dec 30, 2016
Merged

Fix: Socket.unix #3798

merged 1 commit into from Dec 30, 2016

Conversation

maiha
Copy link
Contributor

@maiha maiha commented Dec 29, 2016

Socket.unix is broken due to a tiny typo, and it has no references from spec.

in src/socket.cr:55: undefined constant Type::Stream (did you mean 'Type::STREAM')
  def self.unix(type : Type = Type::Stream, blocking = false)

This PR

  • Fixed Socket.unix
  • Added a simple spec for it to avoid dead code
Socket.unix.family # => UNIX

Thanks.

@ysbaddaden ysbaddaden merged commit 4c5cc9c into crystal-lang:master Dec 30, 2016
@ysbaddaden
Copy link
Contributor

Thank you!

@asterite asterite added this to the 0.20.4 milestone Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind:bug topic:stdlib
Projects
None yet
Milestone
0.20.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maiha @ysbaddaden @asterite