mpd: listen on 127.0.0.1 by default #21505
Conversation
|
@tg-x, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dmalikov, @rickynils and @unaizalakain to be potential reviewers. |
| @@ -83,7 +83,7 @@ in { | |||
|
|
|||
| listenAddress = mkOption { | |||
| type = types.str; | |||
| default = "any"; | |||
| default = "127.0.0.1"; | |||
| description = '' | |||
| This setting sets the address for the daemon to listen on. Careful attention | |||
| should be paid if this is assigned to anything other then the default, any. | |||
There was a problem hiding this comment.
The description still refers to the old default. IMO, it would benefit from some trimming, regardless of this PR (especially the "careful attention" part; I, at least, fail to get anything useful out of it).
|
LGTM but please do update that comment, (but keep that |
|
@tg-x on 33c3 funny things happens, if mpd listens on 0.0.0.0 without a firewall. |
|
"any" could be set as example |
tg-x
force-pushed
the
mpd-listen
branch
2 times, most recently
from
a9971c9
to
1fe16bf
Compare
|
updated description + example |
| This setting sets the address for the daemon to listen on. Careful attention | ||
| should be paid if this is assigned to anything other then the default, any. | ||
| This setting can deny access to control of the daemon. | ||
| This setting sets the address for the daemon to listen on. |
There was a problem hiding this comment.
Nits: a "setting that sets" parses poorly for me. Also, it is unnecessary to state what the default is, as default is shown in the manual to begin with. Finally, I think "any" would render better if enclosed in <literal></literal>.
I'd rephrase as "Listening address" and trust the user to understand how to use it from the example and the default.
There was a problem hiding this comment.
makes sense, trimmed it even further, see updated version
Motivation for this change
MPD is often run on desktop computers where it is not desired to expose the control port publicly,
and thus would be better to have safer defaults.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)