Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audacity: fix library path #21514

Merged
merged 1 commit into from Jan 2, 2017
Merged

audacity: fix library path #21514

merged 1 commit into from Jan 2, 2017

Conversation

peterhoeg
Copy link
Member

Motivation for this change

audacity cannot find the lame and ffmpeg libraries, so we wrap the binary.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@peterhoeg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aske, @abbradar and @vcunat to be potential reviewers.

@abbradar
Copy link
Member

It may be better to do NIX_LDFLAGS = [ "-lflac" ... ]; instead -- this way it won't leak to subprocesses and doesn't require a wrapper.

@LnL7
Copy link
Member

LnL7 commented Dec 30, 2016

@abbradar interesting, that fixes the binary at runtime?

@abbradar
Copy link
Member

@LnL7 Should be -- it would link the library to all the produced binaries, so dlopen finds them without any other measures.

@LnL7
Copy link
Member

LnL7 commented Dec 30, 2016

@abbradar any idea where that happens?

@abbradar
Copy link
Member

@LnL7 You mean where NIX_LDFLAGS is used? Look at our compiler wrappers, specifically pkgs/build-support/cc-wrapper/ld-wrapper.sh.

@peterhoeg
Copy link
Member Author

Thanks for the pointer @abbradar. Much more elegant!

@abbradar
Copy link
Member

abbradar commented Jan 2, 2017

As a side note, I don't think we should fix file warnings case by case (it should be fixed everywhere which is not happening or left as is since it's harmless), but that's just my IMHO. Let's merge, thanks!

@abbradar abbradar merged commit 202e835 into NixOS:master Jan 2, 2017
@peterhoeg peterhoeg deleted the audacity branch January 2, 2017 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants