locate: extend module #21686
Merged
locate: extend module #21686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pngwjpgh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @copumpkin, @edolstra and @andjscott to be potential reviewers. |
|
Bump @copumpkin, @edolstra, @andjscott Care to comment? |
|
@pngwjpgh tested and works for me. Can you rebase your changes against master again? |
|
@Mic92 done |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Support for
mlocatelooked significantly more complete than it turned out to beThings done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)I couldn't find a way to properly handle
includeStoreinrename.nixso I´m just echoing a warning for now. I think a reasonable approach would be to remove/nix/storefromprunePathswhenincludeStoreis set (and print a warning). I could not, however, find a way to do so without running into infinite recursion – any ideas?