Anki: Darwin support #21681

matthewbauer · 2017-01-05T17:35:05Z

Motivation for this change

These are all changes needed to get Anki working on macOS. No changes to the Anki derivation are necessary. However, to run Anki correctly you must set DYLD_FRAMEWORK_PATH correctly until #20484 is fixed:

DYLD_FRAMEWORK_PATH=/System/Library/Frameworks `nix-build '<nixpkgs>' -A anki --no-out-link`/bin/anki

Things done

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

mention-bot · 2017-01-05T17:35:08Z

@matthewbauer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @lovek323, @bjornfor and @urkud to be potential reviewers.

LnL7 · 2017-01-05T18:51:15Z

pkgs/servers/pulseaudio/default.nix

@@ -41,7 +43,8 @@ stdenv.mkDerivation rec {
    sha256 = "11j682g2mn723sz3bh4i44ggq29z053zcggy0glzn63zh9mxdly3";
  };

-  patches = [ ./caps-fix.patch ];
+  patches = [ ./caps-fix.patch ]


Where did this patch come from? It looks like you can probably use fetchpatch instead.

Note this patch was already here

I think he was referring to the below one.

Indeed, the changes are good now apart from the xcode dependency.

LnL7 · 2017-01-05T19:00:47Z

pkgs/development/libraries/portaudio/default.nix

-    [ "--build=x86_64" "--without-oss" "--enable-static" "--enable-shared" ];
+    [ "--disable-mac-universal" ];
+
+  propagatedBuildInputs = stdenv.lib.optionals stdenv.isDarwin [ AudioUnit AudioToolbox CoreAudio CoreServices Carbon ];

  preBuild = stdenv.lib.optionalString stdenv.isDarwin ''
    sed -i '50 i\


Not your changes, but this looks really fragile.

Yep. It's needed here because Makefile is not generated until after configurePhase. We should just modify Makefile.in but the line numbers won't be the same.

I would prefer a patch that fixes the Makefile.in then, if that's possible.

LnL7 · 2017-01-06T10:35:06Z

This builds fine, but running it seems to require xcode. Is that expected?

matthewbauer · 2017-01-06T17:57:26Z

@LnL7 It shouldn't require Xcode. Do you have any clues as to where it uses Xcode?

mdaiter

Just trying to understand some minor changes in here -- looks good, but particularly concerned about the change from linux to unix when the title suggests only Darwin support.

mdaiter · 2017-01-11T10:44:12Z

pkgs/applications/video/mplayer/default.nix

@@ -199,6 +199,6 @@ stdenv.mkDerivation rec {
    homepage = "http://mplayerhq.hu";
    license = "GPL";
    maintainers = [ stdenv.lib.maintainers.eelco stdenv.lib.maintainers.urkud ];
-    platforms = stdenv.lib.platforms.linux;
+    platforms = stdenv.lib.platforms.unix;


Hesitations about changing this to "unix" when the title says "Darwin support". Unix is defined to be Linux, Darwin, FreeBSD, OpenBSD, NetBSD and Illumos; as defined here:

nixpkgs/lib/platforms.nix

Line 21 in 56904d7

unix = linux ++ darwin ++ freebsd ++ openbsd ++ netbsd ++ illumos;

. This might want to be formatted as with stdenv.lib.platforms; linux ++ darwin ; to conform to the header.

I personally don't like being to restrictive with the platforms, IMHO this should include all the platforms that are supported upstream even if they don't necessarily work (yet) in nixpkgs.

mdaiter · 2017-01-11T10:46:19Z

pkgs/development/libraries/qt-4.x/4.8/default.nix

@@ -4,7 +4,7 @@
 , libmng, which, mesaSupported, mesa, mesa_glu, openssl, dbus, cups, pkgconfig
 , libtiff, glib, icu, mysql, postgresql, sqlite, perl, coreutils, libXi
 , buildMultimedia ? stdenv.isLinux, alsaLib, gstreamer, gst_plugins_base
-, buildWebkit ? stdenv.isLinux
+, buildWebkit ? true


Why is this now set to true? Seems like a change for any library dependent on qt-4.8. Why not buildWebkit ? stdenv.isLinux | stdenv.isDarwin?

copumpkin · 2017-01-11T15:05:33Z

pkgs/development/libraries/portaudio/default.nix

@@ -12,30 +13,26 @@ stdenv.mkDerivation rec {
    ++ stdenv.lib.optional (!stdenv.isDarwin) alsaLib;

  configureFlags = stdenv.lib.optionals stdenv.isDarwin
-    [ "--build=x86_64" "--without-oss" "--enable-static" "--enable-shared" ];
+    [ "--disable-mac-universal" ];


Does this flag do any harm when passed into a non-darwin build? I generally try to minimize platform-conditional stuff.

it will just appear on stdenv..isDarwin

That's what I mean. Does it need to be conditional at all? Wouldn't a linux build just ignore the flag?

The conditional is probably not needed but it will cause a rebuild without it.

I also prefer not to use isDarwin conditionals if not necessary, is the resulting rebuild significant?

No, I can change it

LnL7 · 2017-01-11T22:23:32Z

https://gist.github.com/9a33c428ab2748fcba50dd5727600bb4

matthewbauer · 2017-01-11T22:31:46Z

@LnL7 see 7165b38

LnL7 · 2017-01-11T22:33:03Z

Oh, I'll take a closer look at the error then.

vbgl · 2017-01-12T18:12:38Z

gst-plugins-base does not build: ld complains about a missing framework (this is probably unrelated to this PR). After fixing it (patch below), I could build anki, but running it results in SIGSEGV.

OS version: Mac OS X 10.11.6 (15G1212)

--- a/pkgs/development/libraries/gstreamer/legacy/gst-plugins-base/default.nix
+++ b/pkgs/development/libraries/gstreamer/legacy/gst-plugins-base/default.nix
@@ -1,6 +1,7 @@
 { fetchurl, stdenv, pkgconfig, python, gstreamer, xorg, alsaLib, cdparanoia
 , libogg, libtheora, libvorbis, freetype, pango, liboil, glib, cairo, orc
 , libintlOrEmpty
+, darwin
 , # Whether to build no plugins that have external dependencies
   # (except the ALSA plugin).
   minimalDeps ? false
@@ -36,6 +37,8 @@ stdenv.mkDerivation rec {
         liboil ]
     # can't build cdparanoia on darwin
     ++ stdenv.lib.optional (!minimalDeps && !stdenv.isDarwin) cdparanoia
+    ++ stdenv.lib.optional stdenv.isDarwin
+       (with darwin.apple_sdk.frameworks; ApplicationServices)
     ++ libintlOrEmpty;

   NIX_CFLAGS_COMPILE = stdenv.lib.optionalString stdenv.isDarwin "-lintl";

LnL7 · 2017-01-12T19:14:25Z

@vbgl Are you on the latest master? http://hydra.nixos.org/build/46408265

vbgl · 2017-01-12T22:03:58Z

After updating to master, gst-plugins-base indeed builds correctly. But anki still crashes before it starts.

QtWebkit is needed by Anki

- don't use preBuild for patching - leave all of the tests in place (no tests are run anyway)

matthewbauer · 2017-01-18T20:11:31Z

@LnL7 Do you know which derivation requires Xcode to be installed? Most likely it is some bogus version check.

LnL7 · 2017-01-18T20:18:10Z

Oh right, forget about that. It's either fixed or I just did something strange when testing.

LnL7

testing, I'll merge once it's finished.

LnL7 added the 6.topic: darwin Running or building packages on Darwin label Jan 5, 2017

LnL7 approved these changes Jan 5, 2017

View reviewed changes

matthewbauer force-pushed the anki branch from 5aadffa to 8b5a94c Compare January 5, 2017 19:43

LnL7 mentioned this pull request Jan 6, 2017

libpulseaudio questions #21701

Closed

matthewbauer mentioned this pull request Jan 9, 2017

Transmission: Darwin support #21720

Merged

7 tasks

mdaiter suggested changes Jan 11, 2017

View reviewed changes

copumpkin reviewed Jan 11, 2017

View reviewed changes

LnL7 approved these changes Jan 11, 2017

View reviewed changes

matthewbauer added 5 commits January 17, 2017 19:49

mplayer: add darwin platform

0ede727

pulseaudio: fix on Darwin

5c09b22

portaudio: fix on Darwin

6c6db7b

qt4: build webkit on Darwin

74b206b

QtWebkit is needed by Anki

portaudio: fixup patches

2614fa1

- don't use preBuild for patching - leave all of the tests in place (no tests are run anyway)

matthewbauer force-pushed the anki branch from 5b6b04d to 2614fa1 Compare January 18, 2017 01:49

LnL7 approved these changes Jan 18, 2017

View reviewed changes

LnL7 merged commit 2b0ca8d into NixOS:master Jan 18, 2017

matthewbauer deleted the anki branch January 19, 2017 05:40

matthewbauer mentioned this pull request May 24, 2018

anki: "Segmentation fault: 11" on macOS #40956

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Anki: Darwin support #21681

Anki: Darwin support #21681

matthewbauer commented Jan 5, 2017 •

edited by LnL7

mention-bot commented Jan 5, 2017

LnL7 Jan 5, 2017

grahamc Jan 10, 2017

matthewbauer Jan 10, 2017

LnL7 Jan 10, 2017

LnL7 Jan 5, 2017

matthewbauer Jan 5, 2017

LnL7 Jan 5, 2017

LnL7 commented Jan 6, 2017

matthewbauer commented Jan 6, 2017

mdaiter left a comment

mdaiter Jan 11, 2017

LnL7 Jan 11, 2017 •

edited

mdaiter Jan 11, 2017

copumpkin Jan 11, 2017

matthewbauer Jan 11, 2017

copumpkin Jan 11, 2017

matthewbauer Jan 11, 2017

LnL7 Jan 11, 2017

matthewbauer Jan 12, 2017

LnL7 commented Jan 11, 2017

matthewbauer commented Jan 11, 2017

LnL7 commented Jan 11, 2017

vbgl commented Jan 12, 2017

LnL7 commented Jan 12, 2017

vbgl commented Jan 12, 2017

matthewbauer commented Jan 18, 2017

LnL7 commented Jan 18, 2017 •

edited

LnL7 left a comment

Anki: Darwin support #21681

Anki: Darwin support #21681

Conversation

matthewbauer commented Jan 5, 2017 • edited by LnL7

Motivation for this change

Things done

mention-bot commented Jan 5, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LnL7 commented Jan 6, 2017

matthewbauer commented Jan 6, 2017

mdaiter left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LnL7 Jan 11, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LnL7 commented Jan 11, 2017

matthewbauer commented Jan 11, 2017

LnL7 commented Jan 11, 2017

vbgl commented Jan 12, 2017

LnL7 commented Jan 12, 2017

vbgl commented Jan 12, 2017

matthewbauer commented Jan 18, 2017

LnL7 commented Jan 18, 2017 • edited

LnL7 left a comment

Choose a reason for hiding this comment

matthewbauer commented Jan 5, 2017 •

edited by LnL7

LnL7 Jan 11, 2017 •

edited

LnL7 commented Jan 18, 2017 •

edited