Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opencv: upgrade from 3.1.0 to 3.2.0 #22084

Merged
merged 1 commit into from Jan 24, 2017
Merged

Conversation

basvandijk
Copy link
Member

@bjornfor I tested the build by enabling all options (except for enableGtk2).

@mention-bot
Copy link

@basvandijk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @bjornfor and @cpages to be potential reviewers.

@cpages
Copy link
Contributor

cpages commented Jan 24, 2017

Sorry I can't look into it right now, but just a comment that there was an open pr (#21552) for the same. I think it was blocked due to opencv trying to download some stuff during build phase.

@basvandijk
Copy link
Member Author

basvandijk commented Jan 24, 2017

Ah I didn't know about #21552. Thanks for pointing it out to me.

Regarding the downloads during the build phase, I also noticed that myself. What I can do is download these files via fetchurl to the nix store like we do for ippicv.

@basvandijk basvandijk force-pushed the opencv-3.2.0 branch 2 times, most recently from 9ce39e5 to 1cb38d4 Compare January 24, 2017 13:20
@basvandijk
Copy link
Member Author

@cpages Ok I amended the commit and forced pushed it to my PR so that all files that were downloaded during the build are now fetched to the nix store.

This PR should now supersede #21552.

@7c6f434c 7c6f434c merged commit 62b0495 into NixOS:master Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants