gwrap: remove unnecessary checks #21344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
approved these changes
Dec 22, 2016
joachifm
reviewed
Dec 22, 2016
|
|
||
| propagatedBuildInputs = [ libffi ]; | ||
|
|
||
| doCheck = !stdenv.isFreeBSD; # XXX: 00-socket.test hangs |
There was a problem hiding this comment.
Note that doCheck defaults to false; this PR effectively disables the check phase.
There was a problem hiding this comment.
We could change this to doCheck = true;
|
Ping? |
|
Thank you for the ping :) sorry it took so long! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Within gwrap, an OS check is performed to see if the system is using FreeBSD to include a package. However, the gwrap package is set to only build for Linux. Even if the package is set to build for Linux and FreeBSD, a dependency (guile_lib) only builds on GNU platforms, which is currently set to only Linux.
We should remove this unnecessary check, or we should get this package and all dependencies to build (if able) on Linux and FreeBSD.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)