sbot: init at 9d686ee70c6b2073da626fa08e38a8e988b5c5b4 #21809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
reviewed
Jan 12, 2017
|
|
||
| np.buildNodePackage rec { | ||
| version = "9.4.2"; | ||
| name = "sbot-${version}"; |
There was a problem hiding this comment.
Couple things,
- you're actually doing
init at 9.4.2-- can you update the commit message? - can you dedent
versionback to the normal level here?
matthiasbeyer
force-pushed
the
add-sbot
branch
from
dce885e
to
9cac56a
Compare
|
@grahamc fixed what you mentioned, it still does not build though, and I do not know how to resolve this error: |
fpletz
requested changes
Jan 14, 2017
|
@fpletz I would love to - is there a tool available for this or do I have to do it by hand? |
|
@matthiasbeyer add it to pkgs/development/node-packages/node-packages.json and run |
|
@Mic92 umm... I'm not sure what you mean? Add the .nix file to the .json file? Sorry if I'm dumb... |
|
Add your package to |
matthiasbeyer
force-pushed
the
add-sbot
branch
from
9cac56a
to
3c3d1af
Compare
|
@Mic92 Hope that is what you suggested... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Package
sbotThings done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)I need help here. That's actually the first application from the node-js ecosystem I'm trying to package.