irony-server: init at 'same-version-as-irony-of-chosen-elpa` #21815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepfire
force-pushed
the
irony-server
branch
2 times, most recently
from
56a045e
to
2912f08
Compare
deepfire
changed the title
deepfire
force-pushed
the
irony-server
branch
from
2912f08
to
bcc708f
Compare
LnL7
reviewed
Jan 21, 2017
| meta = { | ||
| description = "The server part of irony."; | ||
| homepage = "https://melpa.org/#/irony"; | ||
| license = lib.licenses.free; |
| @@ -5094,6 +5094,8 @@ in | |||
|
|
|||
| intercal = callPackage ../development/compilers/intercal { }; | |||
|
|
|||
| irony-server = callPackage ../development/tools/irony-server/default.nix { }; | |||
There was a problem hiding this comment.
I think it's better to pass in irony as an argument here instead of resolving it in the expression, eg.
irony-server = callPackage ../development/tools/irony-server/default.nix {
inherit (emacsPackagesNg.melpaStablePackages) irony;
};
| in | ||
| stdenv.mkDerivation rec { | ||
| name = "irony-server-${version}"; | ||
| version = irony.version; |
There was a problem hiding this comment.
You could write this as inherit (irony) version;
deepfire
force-pushed
the
irony-server
branch
3 times, most recently
from
63165f3
to
267908e
Compare
|
@LnL7, adjusted to accord with your suggestions. |
deepfire
force-pushed
the
irony-server
branch
from
267908e
to
7ceca3d
Compare
|
@LnL7, thank you for your review! |
LnL7
approved these changes
Jan 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add the
irony-serverpackage, piggybacking on the autogeneratedironypackage from emacsPackagesNg.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)