Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zshrc ordering #21814

Merged
merged 1 commit into from Jan 11, 2017
Merged

Fix zshrc ordering #21814

merged 1 commit into from Jan 11, 2017

Conversation

yacinehmito
Copy link
Contributor

Options in programs.zsh as set before loading the configuration, as opposed to after.

Motivation for this change

I've just been bitten by this. I was attempting to load some completion script in interactiveShellInit but it silently failed because completion was being activated after.
I believe my change to be more sensible ; NixOS does his magic, and then it's up to the user to add his stuff if he wished to.

Things done

See diff.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@gpyh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @makefu, @oxij and @spwhitt to be potential reviewers.

The content of programs.zsh.interactiveShellInit was
inserted too soon in the generated zshrc
This caused some settings related to autocompletion to be ignored
@Mic92 Mic92 merged commit 05a4fbd into NixOS:master Jan 11, 2017
@Mic92
Copy link
Member

Mic92 commented Jan 11, 2017

Thanks!

@makefu
Copy link
Contributor

makefu commented Jan 12, 2017

User config just went a bit deeper again. Until someone needs to have HELPDIR overwritten ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants