there is no reason for basename to return an object

mojolicious · Jan 7, 2017 · c6b1066 · c6b1066
1 parent 7e1e85f
commit c6b1066
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/lib/Mojo/File.pm b/lib/Mojo/File.pm
@@ -21,7 +21,7 @@ use Scalar::Util 'blessed';
 
 our @EXPORT_OK = ('path', 'tempdir');
 
-sub basename { $_[0]->new(scalar File::Basename::basename ${$_[0]}) }
+sub basename { scalar File::Basename::basename ${$_[0]} }
 
 sub child {
   my $self = shift;

diff --git a/lib/Mojo/UserAgent/Transactor.pm b/lib/Mojo/UserAgent/Transactor.pm
@@ -208,7 +208,7 @@ sub _multipart {
         if (my $file = delete $value->{file}) {
           $file = Mojo::Asset::File->new(path => $file) unless ref $file;
           $part->asset($file);
-          $value->{filename} //= path($file->path)->basename->to_string
+          $value->{filename} //= path($file->path)->basename
             if $file->isa('Mojo::Asset::File');
         }
 

diff --git a/lib/Mojolicious/Command/cpanify.pm b/lib/Mojolicious/Command/cpanify.pm
@@ -19,7 +19,7 @@ sub run {
     "https://$user:$password\@pause.perl.org/pause/authenquery" => form => {
       HIDDENNAME                        => $user,
       CAN_MULTIPART                     => 1,
-      pause99_add_uri_upload            => path($file)->basename->to_string,
+      pause99_add_uri_upload            => path($file)->basename,
       SUBMIT_pause99_add_uri_httpupload => ' Upload this file from my disk ',
       pause99_add_uri_uri               => '',
       pause99_add_uri_httpupload        => {file => $file},

diff --git a/lib/Mojolicious/Lite.pm b/lib/Mojolicious/Lite.pm
@@ -21,7 +21,7 @@ sub import {
   push @{"${caller}::ISA"}, 'Mojo';
 
   # Generate moniker based on filename
-  my $moniker = path($ENV{MOJO_EXE})->basename->to_string;
+  my $moniker = path($ENV{MOJO_EXE})->basename;
   $moniker =~ s/\.(?:pl|pm|t)$//i;
   my $app = shift->new(moniker => $moniker);