define abs log2 min functions #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retokromer
reviewed
Jan 7, 2017
| log2(a) The base-two logarithm of a. | ||
|
|
||
| min(a,b) The smallest of two values a and b. | ||
| --------------------- ------------------------------------------------- |
There was a problem hiding this comment.
Sorry, again typography: I suggest either to start with a capital and end with a period, or to start with a minuscule and no period at the end. I prefer the second, because these are not plain sentences.
There was a problem hiding this comment.
updated to the second suggestion (minuscule and no period)
dericed
force-pushed
the
define-more-functions
branch
from
b063410
to
5ac0610
Compare
|
LGTM |
dericed
force-pushed
the
define-more-functions
branch
from
dc4f71a
to
1bda74a
Compare
|
This doesnt merge or cherry pick cleanly |
|
will fix |
partly resolves FFmpeg#36
dericed
force-pushed
the
define-more-functions
branch
from
1bda74a
to
69a377c
Compare
|
conflict resolved, ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partly resolves #36