[#4353] Ignore consecutive DOUBLE_STAR in glob_helper. #4428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumitmah
force-pushed
the
4353-fix-dir-glob
branch
from
9b5135c
to
53593e8
Compare
…return uniq results
sumitmah
force-pushed
the
4353-fix-dir-glob
branch
from
aca8fee
to
b8edd91
Compare
|
najs! any chance for a cleanup or even better use Dir.tmpdir as a base so we do not have to worry about? |
|
@kares In the tests you're asking? |
|
yeah just whatever to cleanup the created dirs e.g. an |
|
@kares done! |
|
@kares I would prefer to wait on this one since it has been wrong since the beginning of JRuby and we can just merge right after 9.1.7.0. |
|
@enebo np, your call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.