frab: init at 2016-12-28 & module #22124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fpletz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @offlinehacker and @bjornfor to be potential reviewers. |
grahamc
reviewed
Jan 25, 2017
| makeWrapper $out/bin/frab-bundle $out/bin/frab-rake \ | ||
| --add-flags "exec rake" | ||
| ''; | ||
| }; |
There was a problem hiding this comment.
I think this frab-rake would be very helpful to expose outside of the module. What do you think?
There was a problem hiding this comment.
Not really. 😄 The problem is that the frab package is probably not usable outside of NixOS because I had to introduce some symlinks to /run for hardcoded paths in Rails itself pointing into the nix store. That's why this wrapper will probably never work without the module.
grahamc
reviewed
Jan 25, 2017
| password = "supersecret"; | ||
| encoding = "utf8"; | ||
| pool = 5; | ||
| }; |
There was a problem hiding this comment.
👍 I love giving this useful example.
grahamc
approved these changes
Jan 25, 2017
globin
approved these changes
Jan 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
frab is a cool conference planning tool (with cfp, session submissions, scheduling, voting, etc.) used and developed for chaos events like the C3 (successor of pentabarf). It might come in handy soon.
It's a pretty standard rails application (with all its nicely hardcoded paths). I've used some ideas from the gitlab module.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)