Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.matplotlib: 1.5.3 -> 2.0.0 #22003

Merged
merged 1 commit into from Jan 30, 2017
Merged

pythonPackages.matplotlib: 1.5.3 -> 2.0.0 #22003

merged 1 commit into from Jan 30, 2017

Conversation

lsix
Copy link
Member

@lsix lsix commented Jan 20, 2017

Motivation for this change

All the derivations that fails to pass nox-review also fails to build before this update:

  • python35Packages.Pweave
  • python35Packages.joblib
  • python35Packages.librosa
  • python35Packages.oger

cc @FRidh

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

7c6f434c
7c6f434c requested changes Jan 20, 2017
View reviewed changes
pkgs/development/python-modules/matplotlib/default.nix
};

NIX_CFLAGS_COMPILE = stdenv.lib.optionalString stdenv.isDarwin "-I${libcxx}/include/c++/v1";

XDG_RUNTIME_DIR = "/tmp";

buildInputs = [ python which sphinx stdenv ]
uildInputs = [ python which sphinx stdenv ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You made a typo here… I guess it has happened after the testing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve fixed and re-pushed it.

I am (re) running nox-review to be sure but that might take some time before I have rebuilt everything (I’ve have had to nix-collect-garbage since I did my previous testing)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this (silly) error.

@FRidh FRidh self-assigned this Jan 20, 2017
@FRidh
Copy link
Member

FRidh commented Jan 21, 2017

Please check http://matplotlib.org/2.0.0/api/api_changes.html
Some backends have been removed, others deprecated. I suppose we don't need Cocoa anymore.

@lsix
Copy link
Member Author

lsix commented Jan 23, 2017

I’ll drop the cocoa backend. Should I completely drop the deprecated backends (such as gtk2) ?

@FRidh
Copy link
Member

FRidh commented Jan 23, 2017

If they're still functioning I don't think they should be dropped.

@lsix
Copy link
Member Author

lsix commented Jan 23, 2017

I’ve pushed an update but I’m waiting for a darwin build to make sure I did not remove to much darwin related dependencies (I do not have such a box available to run proper tests locally).

@FRidh
Copy link
Member

FRidh commented Jan 30, 2017

I’ve pushed an update but I’m waiting for a darwin build to make sure I did not remove to much darwin related dependencies (I do not have such a box available to run proper tests locally).

Let's hope for the best.

@FRidh FRidh merged commit e4f739f into NixOS:master Jan 30, 2017
@georgewhewell georgewhewell mentioned this pull request Feb 13, 2017
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c requested changes

Assignees

@FRidh FRidh

Labels
6.topic: python 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lsix @FRidh @7c6f434c