Fixed: use unused variable in String#<=>

Because all String end with a `\0` this isn't a real problem, as memcmp would stop at that `\0` so there's no unsafe memory access, but this change is still more correct.
crystal-lang · Jan 20, 2017 · 47a3002 · 47a3002
1 parent 42e2a52
commit 47a3002
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/string.cr b/src/string.cr
@@ -2038,7 +2038,7 @@ class String
     return 0 if same?(other)
     min_bytesize = Math.min(bytesize, other.bytesize)
 
-    cmp = to_unsafe.memcmp(other.to_unsafe, bytesize)
+    cmp = to_unsafe.memcmp(other.to_unsafe, min_bytesize)
     cmp == 0 ? (bytesize <=> other.bytesize) : cmp.sign
   end