Skip to content

Commit

Permalink
Revert "cairo: Add ApplicationServices as propagatedBuildInput"
Browse files Browse the repository at this point in the history
This reverts commit 0f67005.
  • Loading branch information
LnL7 committed Jan 9, 2017
1 parent 755c292 commit ab0bb24
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
4 changes: 1 addition & 3 deletions pkgs/development/libraries/cairo/default.nix
Expand Up @@ -48,6 +48,7 @@ stdenv.mkDerivation rec {
] ++ libintlOrEmpty ++ optionals stdenv.isDarwin (with darwin.apple_sdk.frameworks; [
CoreGraphics
CoreText
ApplicationServices
Carbon
]);

Expand All @@ -56,9 +57,6 @@ stdenv.mkDerivation rec {
++ optionals xcbSupport [ libxcb xcbutil ]
++ optional gobjectSupport glib
++ optional glSupport mesa_noglu
++ optionals stdenv.isDarwin (with darwin.apple_sdk.frameworks; [
ApplicationServices
])
; # TODO: maybe liblzo but what would it be for here?

configureFlags = if stdenv.isDarwin then [
Expand Down
7 changes: 5 additions & 2 deletions pkgs/development/libraries/librsvg/default.nix
@@ -1,5 +1,5 @@
{ lib, stdenv, fetchurl, pkgconfig, glib, gdk_pixbuf, pango, cairo, libxml2, libgsf
, bzip2, libcroco, libintlOrEmpty
, bzip2, libcroco, libintlOrEmpty, darwin
, withGTK ? false, gtk3 ? null
, gobjectIntrospection ? null, enableIntrospection ? false }:

Expand All @@ -22,7 +22,10 @@ stdenv.mkDerivation rec {

propagatedBuildInputs = [ glib gdk_pixbuf cairo ] ++ lib.optional withGTK gtk3;

nativeBuildInputs = [ pkgconfig ];
nativeBuildInputs = [ pkgconfig ]
++ lib.optionals stdenv.isDarwin (with darwin.apple_sdk.frameworks; [
ApplicationServices
]);

configureFlags = [ "--enable-introspection=auto" ]
++ stdenv.lib.optional stdenv.isDarwin "--disable-Bsymbolic";
Expand Down

4 comments on commit ab0bb24

@LnL7
Copy link
Member Author

@LnL7 LnL7 commented on ab0bb24 Jan 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke texlive on darwin.

/cc @johbo

@johbo
Copy link
Contributor

@johbo johbo commented on ab0bb24 Jan 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh -- thanks for taking care of the revert @LnL7

@matthewbauer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the broken build: http://hydra.nixos.org/build/46210191/nixlog/1 ?

The error it gives is:

/nix/store/hivwddrri78ipng4v1h8ffq6rwa64kvq-Libsystem-osx-10.11.6/include/os/object.h:74:9: fatal error: 'objc/NSObject.h' file not found
#import <objc/NSObject.h>

That seems to be an issue with libSystem: It needs to propagate the dependency on objc.

@LnL7
Copy link
Member Author

@LnL7 LnL7 commented on ab0bb24 Jan 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somebody on irc mentioned that adding libobjc didn't help.

Please sign in to comment.