[web]: Simplifies circuits.web.HTTP properties by removing useless hasattr/getattr checks #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apollo13
reviewed
Jan 23, 2017
| return "https" if self._server.secure else "http" | ||
|
|
||
| @property | ||
| def base(self): | ||
| if getattr(self, "uri", None) is None: |
There was a problem hiding this comment.
If self.uri is None (ie before the ready handler ran), the line below self.uri.utf8() would error out if. I guess you still need to check if self.uri is None but you can remove the getattr
prologic
force-pushed
the
simplify_HTTP_properties
branch
from
5eaedf0
to
df4d609
Compare
Current coverage is 77.89% (diff: 50.00%)@@ master #211 diff @@
==========================================
Files 80 80
Lines 6641 6637 -4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 5175 5170 -5
- Misses 1466 1467 +1
Partials 0 0
|
|
Review please :) |
apollo13
approved these changes
Jan 23, 2017
spaceone
requested changes
Jan 23, 2017
| if getattr(self, "uri", None) is None: | ||
| return | ||
| if self.uri is None: | ||
| return "" |
There was a problem hiding this comment.
Then the code below is also wrong since it explicitelly decodes ;)
There was a problem hiding this comment.
oh yes... then everything is fine.
spaceone
approved these changes
Jan 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.