Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zulu: init at 8.19.0.1 #22040

Merged
merged 1 commit into from Jan 25, 2017
Merged

zulu: init at 8.19.0.1 #22040

merged 1 commit into from Jan 25, 2017

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Add a certified OpenJDK build.
Azul Zulu is a popular alternative.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I added Darwin and tested it as much as I could but I cannot run it without an actual macOS.

@grahamc
Copy link
Member

grahamc commented Jan 23, 2017

Builds on linux: https://prs.nix.gsc.io/build/3542725

@LnL7
Copy link
Member

LnL7 commented Jan 23, 2017 •
edited

Why does this have a darwin label?

n/m

@LnL7
Copy link
Member

LnL7 commented Jan 23, 2017

libpciaccess is broken on darwin so this doesn't evaluate. I tried to build it anyway but it failed with this.

common_interface.c:72:10: fatal error: 'sys/endian.h' file not found
#include <sys/endian.h>

@NeQuissimus
Copy link
Member Author

NeQuissimus commented Jan 23, 2017 •
edited

Hmm, should I pull the Darwin stuff out for now then?
Thank you for testing.

@LnL7
Copy link
Member

LnL7 commented Jan 23, 2017

I would leave it in if the package is supposed to work on darwin.

@7c6f434c
Copy link
Member

What does «certified» mean here, i.e. does patching RPATH break it in some sense (this question is mostly about description)?

@NeQuissimus
Copy link
Member Author 

Zulu is verified compliant with the Java SE specifications using the OpenJDK Community Technology Compatibility Kit (TCK)

It basically means it is a drop-in replacement for any other JDK build that follows the TCK.

@7c6f434c 7c6f434c merged commit 05d7ece into NixOS:master Jan 25, 2017
@NeQuissimus NeQuissimus deleted the zulu branch January 25, 2017 14:07
@NeQuissimus NeQuissimus restored the zulu branch January 27, 2017 00:47
@NeQuissimus NeQuissimus deleted the zulu branch January 27, 2017 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 9.needs: community feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NeQuissimus @grahamc @LnL7 @7c6f434c