neofetch: init at 2.0.2 #22036
Merged
neofetch: init at 2.0.2 #22036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Jan 22, 2017
| "PREFIX=" | ||
| ]; | ||
|
|
||
| meta = { |
There was a problem hiding this comment.
there a small error in your package:
diff --git a/pkgs/tools/misc/neofetch/default.nix b/pkgs/tools/misc/neofetch/default.nix
index 01c79a7e4d..0e992f49c7 100644
--- a/pkgs/tools/misc/neofetch/default.nix
+++ b/pkgs/tools/misc/neofetch/default.nix
@@ -23,11 +23,11 @@ stdenv.mkDerivation rec {
"PREFIX="
];
- meta = {
+ meta = with stdenv.lib; {
description = "A fast, highly customizable system info script";
homepage = https://github.com/dylanaraps/neofetch;
- license = stdenv.lib.licenses.mit;
- platforms = stdenv.lib.platforms.all;
+ license = licenses.mit;
+ platforms = platforms.all;
maintainers = with maintainers; [ alibabzo ];
};
}There was a problem hiding this comment.
Oh yep, thanks
I'll make the change now and squash the commit
|
Thanks for the quick turnaround, @Mic92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Neofetch is a useful system utility which is in many distro repositories. It's not yet in nixpkgs.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)