Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paratype-pt-sane: s/sane/sans/ #22029

Merged
merged 1 commit into from Jan 22, 2017
Merged

paratype-pt-sane: s/sane/sans/ #22029

merged 1 commit into from Jan 22, 2017

Conversation

Minoru
Copy link
Contributor

@Minoru Minoru commented Jan 22, 2017

Motivation for this change

The typo in the name of the package makes it much harder to find.

Things done

Is there more extensive documentation on these checks? The info available in this list and in the Nix manual wasn't sufficient for me to perform them. A lot of PRs get merged without any of these boxes checked, though, so I won't explain the troubles I run into unless someone wants me to.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jan 22, 2017

I thought the commit template is explains itself and contains links. Is there a specific question, you have? In this case no functionality changes, but other pull request do more invasive changes
so it is good to know on which platforms it was tested for example.

@Mic92 Mic92 merged commit cb602a4 into NixOS:master Jan 22, 2017
@Minoru Minoru deleted the patch-1 branch January 22, 2017 17:09
@Minoru
Copy link
Contributor Author

Minoru commented Jan 22, 2017

The checklist seem to be geared towards people who know what they're doing locally and need only a couple of pointers to figure out what Nixpkgs maintainers need to consider the changes tested. Me being a drive-by contributor with zero experience in writing my own derivations or anything, plus not much time right now to dive into all this stuff (notice the commit date is a week ago?), it presented an insurmountable challenge. The most specific question I can come up with is: where can I find the more extensive documentation on contributing? Not just a list of things I can do with Nix—i.e. not the Nix manual—but specific steps of how I build and test my changes before submitting a PR.

If you're interested what I ran into specifically, here goes.

I've set nix.useSandbox = true in my /etc/nixos/configuration.nix, ran nixos-rebuild switch, and… then what? I assumed I should try nix-build; I ran nix-build sans.nix in pkgs/data/fonts/paratype-pt, but it gave me an error: "cannot auto-call a function that has an argument without a default value (‘stdenv’)". I skimmed the synopsis in the man page, didn't see a clear way forward, and gave up.

nix-shell -p nox --run 'nox-review wip' said it "must be run in a nix repository". But isn't pkgs/data/fonts/paratype-pt a "nix repository"? Again, I gave up.

The third item is the only one I knew what to do about. Fonts don't contain executables :)

Regarding the fourth item: it seems that the box should be ticked by a person who reviews the PR, but then it's not clear why it's even in the checklist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants