Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namecoind: refactor nixos module #22044

Merged
merged 1 commit into from Feb 3, 2017
Merged

namecoind: refactor nixos module #22044

merged 1 commit into from Feb 3, 2017

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jan 23, 2017

Motivation for this change

See #21999

needs #22041 to be merged first.

Things done
  • Tested using sandboxing
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change (none)
  • Tested execution of all binary files (none)
  • Fits CONTRIBUTING.md.

@layus
Copy link
Member

layus commented Jan 23, 2017

Hi, the travis build fails with what seems a valid error : The option services.dnschain.namecoin' defined in /home/travis/build/NixOS/nixpkgs/nixos/modules/services/networking/namecoind.nix' does not exist.
Can you reproduce this locally ?

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jan 23, 2017

Oh right. It's not defined because it needs another PR merged before. Namely #22041 .

@layus layus mentioned this pull request Jan 23, 2017
7 tasks
@joachifm joachifm merged commit a3ff62d into NixOS:master Feb 3, 2017
@rnhmjoj rnhmjoj deleted the namecoin branch September 12, 2017 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants