DNSChain: fix broken package and improve service #22041
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
joachifm
reviewed
Jan 23, 2017
| ''; | ||
|
|
||
| dns.address = mkOption { | ||
| type = types.string; |
There was a problem hiding this comment.
Probably should be types.str unless you want the peculiar merge semantics of string
There was a problem hiding this comment.
Right, I meant to use str.
|
|
||
| let | ||
| np = nodePackages.override { generated = ./package.nix; self = np; }; | ||
| in | ||
| nodePackages = callPackage (import ../../top-level/node-packages.nix) { |
There was a problem hiding this comment.
What is the motivation for the move to this construction instead of taking the package set as a parameter? Does override not work?
There was a problem hiding this comment.
Yes, it produces the error:
called with unexpected argument ‘self’, at <nixpkgs>/lib/customisation.nix:56:12
I looked how other nodejs packages handle this and switched to use callPackage.
|
Looks like there is an error building this: |
|
Strange, it builds for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
See #21999
Things done