Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnscrypt-wrapper: add service #22043

Merged
merged 1 commit into from Jan 23, 2017
Merged

dnscrypt-wrapper: add service #22043

merged 1 commit into from Jan 23, 2017

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jan 23, 2017 •
edited

Motivation for this change

See #21999

Things done
  • Tested using sandboxing
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change (none)
  • Tested execution of all binary files (none)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@rnhmjoj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @offlinehacker and @bjornfor to be potential reviewers.

@offlinehacker
Copy link
Contributor

looks good to me :)

@offlinehacker offlinehacker merged commit 90e0ed3 into NixOS:master Jan 23, 2017
@layus
Copy link
Member

layus commented Jan 23, 2017 •
edited

@offlinehacker Would you mind reviewing #22041, #22042, #22044, #22045 as they are all related ? Merging this one alone is pointless. (see #21999)

@rnhmjoj rnhmjoj deleted the dnscrypt-wrapper branch February 15, 2017 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rnhmjoj @mention-bot @offlinehacker @layus